Merged
Conversation
🐳 Expected TagsSome Dockerfiles have been modified in this PR. New tags are expected to be deployed.
|
…l pin the solved versions
Johnnyassaf
approved these changes
Jan 6, 2026
Contributor
Johnnyassaf
left a comment
There was a problem hiding this comment.
Solved by specifically unpinning R from 4.3.1 to 4.4.3, if we want to keep R low, then we need to keep fraser at 1.14.1, which would not be ideal
MattWellie
commented
Jan 6, 2026
images/fraser/Dockerfile
Outdated
| r-base=4.4.3 \ | ||
| r-reshape2=1.4.5 \ | ||
| r-tidyverse=2.0.0 \ | ||
| bioconductor-fraser=2.4.6 \ |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| bioconductor-fraser=2.4.6 \ | |
| bioconductor-fraser=${VERSION} \ |
this should be using the tag directly
…sful run batch 1125169
3 tasks
Johnnyassaf
added a commit
to populationgenomics/cpg-flow-rdrnaseq
that referenced
this pull request
Feb 18, 2026
## Refactor FRASER pipeline with separated R scripts and improved job management ### Summary Major refactoring of the FRASER aberrant splicing analysis pipeline, including version bump from 0.2.5 to 1.0.0. ### Changes #### FRASER Pipeline Refactoring (`src/rdrnaseq/jobs/fraser.py`) - **Separated R scripts**: Broke monolithic FRASER R code into modular scripts that are baked into and retrieved from a Fraser Image : populationgenomics/images#272 - `fraser_init.R` - Initialize FRASER object - `fraser_count_split.R` - Count split reads per sample - `fraser_merge_split.R` - Merge split read counts across samples - `fraser_count_non_split.R` - Count non-split reads per sample - `fraser_merge_non_split.R` - Merge non-split read counts - `fraser_join_counts.R` - Join all count matrices - `fraser_analysis.R` - Run FRASER analysis and generate results - **New `get_fraser_job()` helper function**: Centralized job creation with consistent resource allocation based on `MachineType` (HIGHMEM/STANDARD) - **Configurable job resources**: Added config-driven storage and CPU allocation: - `cohort_job_resources`: For multi-sample jobs (base_storage_gb, per_bam_storage, ncpu) - `sample_job_resources`: For single-sample jobs - **Improved job dependency management**: Fixed job dependency chains to ensure proper execution order across pipeline stages - **File caching fixes**: Implemented proper output existence checking to skip completed steps - **Storage optimization**: Intermediate results now saved to temporary GCS storage, with significant results saved permanently #### Stage Updates (`src/rdrnaseq/stages.py`) - Updated Fraser stage with new analysis keys: `Rds_data`, `seqr_data`, `sig_results` - Improved CRAM→BAM conversion tracking to avoid duplicate conversions across stages - Added `samples_needing_bams` tracking dict for cross-stage job dependencies #### Configuration (`src/rdrnaseq/config_template.toml`) - Added `cohort_job_resources` section for cohort-level job configuration - Added `sample_job_resources` section for sample-level job configuration #### Cleanup - Removed deprecated `picard.py` module (465 lines deleted) - Updated README with current pipeline usage - Updated Docker image reference - Version bump: 0.2.5 → 1.0.0 Co-authored-by: Matt Welland <mattwellie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.